Page MenuHomePhabricator
Differential D4818

Add sig files to Github release
ClosedPublic
Actions

Authored by jasonbcox on Jan 2 2020, 17:23.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING0d793ae6bd79: Add sig files to Github release
rABC0d793ae6bd79: Add sig files to Github release
Summary

Currently, our release signatures are available on download.bitcoinabc.org but not on the Github release.
This patch fixes that, making the sigs more easy to find by users.

Test Plan

github-release.sh -d -a <asset-path> -o <oauth-token-path> -t v0.20.9
Verify the output indicates the sig files from the previous release would be uploaded.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
github-upload-sigs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8705
Build 15395: Default Diff Build & Tests
Build 15394: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 2 2020, 17:23
Herald added a reviewer: deadalnix. · View Herald TranscriptJan 2 2020, 17:23
teamcity added a comment.Jan 2 2020, 17:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 2 2020, 17:33

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8705: Diff 15105.Jan 2 2020, 17:33
deadalnix accepted this revision.Jan 2 2020, 17:46
This revision is now accepted and ready to land.Jan 2 2020, 17:46
jasonbcox updated this revision to Diff 15108.Jan 2 2020, 18:15

Made the sig file wildcard a bit more restrictive, so as to not accidentally upload sig files from old versions.

teamcity added a comment.Jan 2 2020, 18:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Jan 2 2020, 18:24
teamcity added a comment.Jan 2 2020, 18:24

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8706: Diff 15108.Jan 2 2020, 18:24
Closed by commit rABC0d793ae6bd79: Add sig files to Github release (authored by jasonbcox). · Explain WhyJan 2 2020, 18:31
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC0d793ae6bd79: Add sig files to Github release.
jasonbcox added a commit: rSTAGING0d793ae6bd79: Add sig files to Github release.Apr 7 2020, 22:15

Revision Contents
Changeset List

PathSize
contrib/
devtools/
5 lines

Diff 15105

View Options

contrib/devtools/github-release.sh

Loading...