Page MenuHomePhabricator
Differential D4833

Add pippenger_wnaf for multi-multiplication
ClosedPublic
Actions

Authored by deadalnix on Jan 4 2020, 15:24.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING45303b515401: Add pippenger_wnaf for multi-multiplication
rABC45303b515401: Add pippenger_wnaf for multi-multiplication
Summary

Backport PR486 and PR510

Test Plan

Run bench_ecmult after building both with autotools and cmake.
Run secp256k1 test suite.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secppippenger
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8736
Build 15456: Default Diff Build & Tests
Build 15455: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 4 2020, 15:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2020, 15:24
teamcity added a comment.Jan 4 2020, 15:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 4 2020, 15:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8736: Diff 15152.Jan 4 2020, 15:28
Mengerian added a subscriber: Mengerian.Jan 7 2020, 04:17

Since it's coming from a different repo than most ABC backports, the Diff summary should mention what repo these backports are coming from and/or link to them

https://github.com/bitcoin-core/secp256k1/pull/486
https://github.com/bitcoin-core/secp256k1/pull/510

jasonbcox accepted this revision.Jan 8 2020, 22:48
jasonbcox added a subscriber: jasonbcox.

Please write a runnable test plan.

This revision is now accepted and ready to land.Jan 8 2020, 22:48
Closed by commit rABC45303b515401: Add pippenger_wnaf for multi-multiplication (authored by deadalnix). · Explain WhyJan 9 2020, 11:04
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC45303b515401: Add pippenger_wnaf for multi-multiplication.
deadalnix added a commit: rSTAGING45303b515401: Add pippenger_wnaf for multi-multiplication.Apr 7 2020, 22:20

Revision Contents
Changeset List

PathSize
src/
secp256k1/
1 line
8 lines
include/
35 lines
src/
16 lines
196 lines
15 lines
18 lines
7 lines
723 lines
3 lines
6 lines
35 lines
77 lines
12 lines
484 lines
41 lines
8 lines

Diff 15152

View Options

src/secp256k1/CMakeLists.txt

Loading...
View Options

src/secp256k1/Makefile.am

Loading...
View Options

src/secp256k1/include/secp256k1.h

Loading...
View Options

src/secp256k1/src/bench.h

Loading...
View Options

src/secp256k1/src/bench_ecmult.c

Loading...
View Options

src/secp256k1/src/bench_internal.c

Loading...
View Options

src/secp256k1/src/ecmult.h

Loading...
View Options

src/secp256k1/src/ecmult_const_impl.h

Loading...
View Options

src/secp256k1/src/ecmult_impl.h

Loading...
View Options

src/secp256k1/src/group.h

Loading...
View Options

src/secp256k1/src/group_impl.h

Loading...
View Options

src/secp256k1/src/scratch.h

Loading...
View Options

src/secp256k1/src/scratch_impl.h

Loading...
View Options

src/secp256k1/src/secp256k1.c

Loading...
View Options

src/secp256k1/src/tests.c

Loading...
View Options

src/secp256k1/src/tests_exhaustive.c

Loading...
View Options

src/secp256k1/src/util.h

Loading...