Page MenuHomePhabricator

GUI: Change the receive button to respond to keypool state changing
ClosedPublic

Authored by deadalnix on Jan 6 2020, 13:46.

Details

Summary
  • Check for more than private keys disabled to show receive button
  • Notify the GUI that the keypool has changed to set the receive button

Whenever the keypool changes (new keys generated, new seed set,
keypool runs out, etc.), notify the GUI that the keypool has changed. The
receive button can then be enabled and disabled as necessary.

This is a backport of Core PR15225

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien requested changes to this revision.Jan 6 2020, 16:17
Fabien added a subscriber: Fabien.

Is there any way to test this without PR15226 ?

src/qt/walletmodel.cpp
436 ↗(On Diff #15175)

Use std::bind

This revision now requires changes to proceed.Jan 6 2020, 16:17
src/qt/walletmodel.cpp
436 ↗(On Diff #15175)

It's boost bind in core still. Not sure if it matters.

Not sure about testing. PR15226 is indeed to next in my queue.

Fabien added inline comments.
src/qt/walletmodel.cpp
436 ↗(On Diff #15175)

I just checked and you're right, it's still there... And it's the only occurrence in the codebase. That looks like a mistake to me, furthermore bind.hpp is never included.

This revision is now accepted and ready to land.Jan 6 2020, 16:35