Page MenuHomePhabricator

[SECP256K1] Move the autotools Travis build to it's own script
ClosedPublic

Authored by Fabien on Wed, Jan 8, 14:35.

Details

Summary

This will make it easier to follow when introducing the cmake build into
Travis.

There is no change in behavior.

Test Plan

Run the script, run the travis build.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Jan 8, 14:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 8, 14:35
deadalnix requested changes to this revision.Wed, Jan 8, 17:32
deadalnix added inline comments.
src/secp256k1/.travis.yml
60 ↗(On Diff #15223)

contrib doesn't seems to be the right place for this project. There is code in there.

This revision now requires changes to proceed.Wed, Jan 8, 17:32
Fabien updated this revision to Diff 15255.Thu, Jan 9, 08:04

Address feedbacks (also from D4856):

  • Move the scripts out of contrib/
  • Set the locale (the linter didn't throw because secp256k1 is excluded, I will update this in another diff)
  • Use set -x instead of set -v for consistency
  • Don't export script scoped variables.
deadalnix accepted this revision.Thu, Jan 9, 11:31
This revision is now accepted and ready to land.Thu, Jan 9, 11:31