Page MenuHomePhabricator

[SECP256K1] Move the autotools Travis build to it's own script
ClosedPublic

Authored by Fabien on Jan 8 2020, 14:35.

Details

Summary

This will make it easier to follow when introducing the cmake build into
Travis.

There is no change in behavior.

Test Plan

Run the script, run the travis build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1_travis_autotools_script
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8811
Build 15597: Default Diff Build & Tests
Build 15596: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Jan 8 2020, 17:32
deadalnix added inline comments.
src/secp256k1/.travis.yml
60 ↗(On Diff #15223)

contrib doesn't seems to be the right place for this project. There is code in there.

This revision now requires changes to proceed.Jan 8 2020, 17:32

Address feedbacks (also from D4856):

  • Move the scripts out of contrib/
  • Set the locale (the linter didn't throw because secp256k1 is excluded, I will update this in another diff)
  • Use set -x instead of set -v for consistency
  • Don't export script scoped variables.
This revision is now accepted and ready to land.Jan 9 2020, 11:31