This adds a CMake build script to be run by Travis.
Since some configuration switches are not part of the CMake options,
only the relevant combinations are used for the CMake builds.
Depends on D4855.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGINGce8bfb5331ba: [SECP256k1] Add the CMake/Ninja build to Travis
rABCce8bfb5331ba: [SECP256k1] Add the CMake/Ninja build to Travis
Run the travis build.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- secp256k1_travis_cmake
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8826 Build 15627: Default Diff Build & Tests Build 15626: arc lint + arc unit
Event Timeline
Comment Actions
I don't think the contrib folder on secp256k1 is meant to be used this way.
| src/secp256k1/contrib/travis/build_cmake.sh | ||
|---|---|---|
| 3 ↗ | (On Diff #15224) | We really need a linter to make these consistent. Also, why isn't the linter yelling at you for local related things? |
| 6 ↗ | (On Diff #15224) | I don't think export here is correct. |
| src/secp256k1/.travis.yml | ||
|---|---|---|
| 67 ↗ | (On Diff #15256) | That should probably be two different build plans. |
Comment Actions
Use separated build plans for cmake.
Only run the supported configurations on cmake.
Convert EXTRAFLAGS to cmake syntax as CMAKE_EXTRA.
| src/secp256k1/.travis.yml | ||
|---|---|---|
| 41 ↗ | (On Diff #15276) | The whole point of the matrix thing is that you can leverage it to go combinatorial, and you don't need to do it yourself. |
| 84 ↗ | (On Diff #15276) | Same here, you can just leverage the matrix thing to do the combinatorial for you. |
| src/secp256k1/travis/build_cmake.sh | ||
| 12 ↗ | (On Diff #15276) | That doesn't look like a flag that cmake uses. |
| src/secp256k1/.travis.yml | ||
|---|---|---|
| 41 ↗ | (On Diff #15276) | There is no way to expand the matrix if this is not natively supported as a keyword, such as os or compiler. |
| src/secp256k1/travis/build_cmake.sh | ||
| 12 ↗ | (On Diff #15276) | It disables the use of the GMP library, since it's a cache variable. |
Comment Actions
Roll back to previous version. Rationale:
Pros:
- It improves readability and maintenability a lot.
- Running duplicated test is free, so it's not a big deal. Once we reach feature parity the duplicated tests will disappear.
Cons:
- If the autotools buid fails, it can hide a cmake failure since it's the same test plan.