Page MenuHomePhabricator
Differential D4862

Added guide for OSX users on how to install clang-format-8.
ClosedPublic
Actions

Authored by tobias_ruck on Jan 8 2020, 15:35.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING55577b249220: Added guide for OSX users on how to install clang-format-8.
rABC55577b249220: Added guide for OSX users on how to install clang-format-8.
Summary

Added the command that allowed me to use clang-format-8 without having to recompile llvm & clang to CONTRIBUTING.md.

Test Plan

I ran npm install -g clang-format@1.2.4. I had to delete/move some files due to conflicts with another installation, but after that, running arc diff succeeded. A fresh installation should work with just that command; otherwise the instructions can be amended to accomodate for additional problems.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
OP_BSWAP
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8790
Build 15561: Default Diff Build & Tests
Build 15560: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jan 8 2020, 15:35
Owners added a reviewer: Restricted Owners Package.Jan 8 2020, 15:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2020, 15:35
teamcity added a comment.Jan 8 2020, 15:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 8 2020, 15:53

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8790: Diff 15231.Jan 8 2020, 15:53
Fabien accepted this revision.Jan 8 2020, 16:34
Fabien added a subscriber: Fabien.

Tested working on Catalina.

This revision is now accepted and ready to land.Jan 8 2020, 16:34
tobias_ruck edited the test plan for this revision. (Show Details)Jan 9 2020, 00:11
Closed by commit rABC55577b249220: Added guide for OSX users on how to install clang-format-8. (authored by tobias_ruck). · Explain WhyJan 9 2020, 11:29
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC55577b249220: Added guide for OSX users on how to install clang-format-8..
tobias_ruck added a commit: rSTAGING55577b249220: Added guide for OSX users on how to install clang-format-8..Apr 7 2020, 22:20

Revision Contents
Changeset List

PathSize
6 lines

Diff 15231

View Options

CONTRIBUTING.md

Loading...