Page MenuHomePhabricator
Differential D4888

Add Clang thread safety annotations for variables guarded by cs_db
ClosedPublic
Actions

Authored by Fabien on Jan 10 2020, 19:20.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGf6217c896d7e: Add Clang thread safety annotations for variables guarded by cs_db
rABCf6217c896d7e: Add Clang thread safety annotations for variables guarded by cs_db
Summary

Backport of core PR13127:
https://github.com/bitcoin/bitcoin/pull/13127/files

Depends on D4886.

Test Plan
cmake -GNinja .. -DENABLE_WERROR=ON
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13127
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8838
Build 15651: Default Diff Build & Tests
Build 15650: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 10 2020, 19:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2020, 19:20
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 10 2020, 19:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 10 2020, 19:25

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8838: Diff 15303.Jan 10 2020, 19:25
Fabien updated this revision to Diff 15313.Jan 10 2020, 21:16

Rebase.

Fabien added a child revision: D4891: Free BerkeleyEnvironment instances when not in use.Jan 10 2020, 21:21
teamcity added a comment.Jan 10 2020, 21:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 10 2020, 22:12

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8841: Diff 15313.Jan 10 2020, 22:12
jasonbcox accepted this revision.Jan 10 2020, 22:24
This revision is now accepted and ready to land.Jan 10 2020, 22:24
Closed by commit rABCf6217c896d7e: Add Clang thread safety annotations for variables guarded by cs_db (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJan 10 2020, 22:30
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf6217c896d7e: Add Clang thread safety annotations for variables guarded by cs_db.
Fabien added a commit: rSTAGINGf6217c896d7e: Add Clang thread safety annotations for variables guarded by cs_db.Apr 7 2020, 22:22

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines

Diff 15303

View Options

src/wallet/db.cpp

Loading...