Page MenuHomePhabricator
Differential D4890

Wrap paths in codeblocks in release-process.md
ClosedPublic
Actions

Authored by jasonbcox on Jan 10 2020, 19:51.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5c61837cc260: Wrap paths in codeblocks in release-process.md
rABC5c61837cc260: Wrap paths in codeblocks in release-process.md
Summary

These will render nicely and paths containing * break vim's syntax highlighter without the codeblock wrapper present.

Test Plan

Read it.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
release-process-nits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8845
Build 15665: Default Diff Build & Tests
Build 15664: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 10 2020, 19:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2020, 19:51
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 10 2020, 19:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 10 2020, 20:09

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8840: Diff 15305.Jan 10 2020, 20:09
Fabien requested changes to this revision.Jan 10 2020, 21:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-process.md
21 ↗(On Diff #15305)

Update this one to make it consistent;

22 ↗(On Diff #15305)

Also this path deserve some backquotes.

This revision now requires changes to proceed.Jan 10 2020, 21:44
jasonbcox updated this revision to Diff 15322.Jan 10 2020, 22:56

Switch backticks in section 3 to a link

teamcity added a comment.Jan 10 2020, 22:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 10 2020, 23:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8845: Diff 15322.Jan 10 2020, 23:08
deadalnix accepted this revision.Jan 10 2020, 23:33
Fabien accepted this revision.Jan 11 2020, 13:33
This revision is now accepted and ready to land.Jan 11 2020, 13:33
Closed by commit rABC5c61837cc260: Wrap paths in codeblocks in release-process.md (authored by jasonbcox). · Explain WhyJan 11 2020, 16:50
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC5c61837cc260: Wrap paths in codeblocks in release-process.md.
jasonbcox added a commit: rSTAGING5c61837cc260: Wrap paths in codeblocks in release-process.md.Apr 7 2020, 22:22

Revision Contents
Changeset List

PathSize
doc/
10 lines

Diff 15322

View Options

doc/release-process.md

Loading...