Paths

Table of Contentst

Merge #13988: Add checks for settxfee reasonableness
ClosedPublic
Actions

Authored by nakihito on Jan 11 2020, 01:50.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING5262a13f0300: Merge #13988: Add checks for settxfee reasonableness
rABC5262a13f0300: Merge #13988: Add checks for settxfee reasonableness

Summary

317f2cb3f4499afbaa63e3cac80567744f12c95b test: Check RPC settxfee errors (João Barbosa)
48618daf262b84c2e2f7322b5ca14375d7d68b64 Add checks for settxfee reasonableness (Anthony Towns)

Pull request description:

When using the `settxfee` RPC, the value is silently ignored if it is less than either than minrelaytxfee or the wallet's mintxfee. This adds an error response if that's going to happen, but still allows "settxfee 0" to deliberately default to the minimum value.

Tree-SHA512: ce685584cf8d6b9ca2cc97196d494220e3892b6a804a458086e04b3a23df281da432ad0a3053106a064c90c541ddb6f6b96a27cf8376d45af1e44449baf88456

Backport of Core PR13988
https://github.com/bitcoin/bitcoin/pull/13988/

Note: we don't have a wallet_bumpfee.py test, so the second commit (https://github.com/bitcoin/bitcoin/pull/13988/commits/317f2cb3f4499afbaa63e3cac80567744f12c95b) was added to rpc_estimatefee.py because it seemed to be the most closely related test

Test Plan

make check
test_runner.py rpc_estimatefee

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Jan 11 2020, 01:50

Owners added a reviewer: Restricted Owners Package.Jan 11 2020, 01:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2020, 01:50

nakihito planned changes to this revision.Jan 11 2020, 01:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8847: Diff 15326.Jan 11 2020, 01:55

nakihito requested review of this revision.Jan 11 2020, 02:17

nakihito edited the summary of this revision. (Show Details)

deadalnix accepted this revision.Jan 11 2020, 16:35

This revision is now accepted and ready to land.Jan 11 2020, 16:35

Closed by commit rABC5262a13f0300: Merge #13988: Add checks for settxfee reasonableness (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJan 13 2020, 18:30

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC5262a13f0300: Merge #13988: Add checks for settxfee reasonableness.

nakihito added a commit: rSTAGING5262a13f0300: Merge #13988: Add checks for settxfee reasonableness.Apr 7 2020, 22:25

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

16 lines

test/

functional/

rpc_estimatefee.py

13 lines

Diff 15412

View Options

src/wallet/rpcwallet.cpp