Page MenuHomePhabricator

remove segwit 'sigops cost' leftovers
ClosedPublic

Authored by markblundeberg on Sat, Jan 11, 11:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe4a435d58f82: remove segwit 'sigops cost' leftovers
Summary

In the segwit PR 8149, sigops count was quadrupled to become 'sigops cost',
Several places were still using the quadrupled value and the 'sigops cost'
name too.

https://github.com/bitcoin/bitcoin/pull/8149/commits/2b1f6f9ccf36f1e0a2c9d99154e1642f796d7c2b

Test Plan

ninja all check bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Sat, Jan 11, 11:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Jan 11, 11:45
markblundeberg planned changes to this revision.Sat, Jan 11, 11:58

also rename virtualtxsize args

deadalnix requested changes to this revision.Sat, Jan 11, 13:31

Please consistently use sigOpCount instead of randomly adding it or not.

src/miner.h
194 ↗(On Diff #15332)

packageSigOpsCount

This revision now requires changes to proceed.Sat, Jan 11, 13:31

prefer name like 'sig op count'; caught a few more mentions of 'cost'

deadalnix accepted this revision.Sun, Jan 12, 13:58
This revision is now accepted and ready to land.Sun, Jan 12, 13:58