Page MenuHomePhabricator

scripted-diff: Remove unused first argument to addUnchecked
ClosedPublic

Authored by deadalnix on Sun, Jan 12, 16:31.

Details

Summary

-BEGIN VERIFY SCRIPT-
git grep -l addUnchecked | xargs sed --regexp-extended -i -e 's/addUnchecked\([^)][^,]+,\s*/addUnchecked(/g'
-END VERIFY SCRIPT-

This is a partial backport of Core PR13792 : https://github.com/bitcoin/bitcoin/pull/13792/commits/fa587773e59721e187cadc998f4dc236ad3aef0b

It was tweaked due to differences in our codebase.

Depends on D4914

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sun, Jan 12, 16:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Jan 12, 16:31
markblundeberg requested changes to this revision.Mon, Jan 13, 01:17
markblundeberg added a subscriber: markblundeberg.

Ah fantastic, I was planning to do this at some point. Please fix rebase conflict (D4898 landed) but otherwise looks good, also include make bench-bitcoin (or whatever) in the test plan just to make sure that compiles too.

This revision now requires changes to proceed.Mon, Jan 13, 01:17
deadalnix updated this revision to Diff 15380.Mon, Jan 13, 01:45

rebase and merge conflict. Run the benchmarks

markblundeberg accepted this revision.Mon, Jan 13, 05:09
This revision is now accepted and ready to land.Mon, Jan 13, 05:09