Page MenuHomePhabricator

scripted-diff: Remove unused first argument to addUnchecked
ClosedPublic

Authored by deadalnix on Jan 12 2020, 16:31.

Details

Summary

-BEGIN VERIFY SCRIPT-
git grep -l addUnchecked | xargs sed --regexp-extended -i -e 's/addUnchecked\([^)][^,]+,\s*/addUnchecked(/g'
-END VERIFY SCRIPT-

This is a partial backport of Core PR13792 : https://github.com/bitcoin/bitcoin/pull/13792/commits/fa587773e59721e187cadc998f4dc236ad3aef0b

It was tweaked due to differences in our codebase.

Depends on D4914

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13792
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8880
Build 15735: Default Diff Build & Tests
Build 15734: arc lint + arc unit

Event Timeline

markblundeberg added a subscriber: markblundeberg.

Ah fantastic, I was planning to do this at some point. Please fix rebase conflict (D4898 landed) but otherwise looks good, also include make bench-bitcoin (or whatever) in the test plan just to make sure that compiles too.

This revision now requires changes to proceed.Jan 13 2020, 01:17

rebase and merge conflict. Run the benchmarks

This revision is now accepted and ready to land.Jan 13 2020, 05:09