scripted-diff: Remove unused first argument to addUnchecked
ClosedPublic
Actions

Authored by deadalnix on Jan 12 2020, 16:31.

Details

Reviewers

markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGING49330c5d3cd2: scripted-diff: Remove unused first argument to addUnchecked
rABC49330c5d3cd2: scripted-diff: Remove unused first argument to addUnchecked

Summary

-BEGIN VERIFY SCRIPT-
git grep -l addUnchecked | xargs sed --regexp-extended -i -e 's/addUnchecked\([^)][^,]+,\s*/addUnchecked(/g'
-END VERIFY SCRIPT-

This is a partial backport of Core PR13792 : https://github.com/bitcoin/bitcoin/pull/13792/commits/fa587773e59721e187cadc998f4dc236ad3aef0b

It was tweaked due to differences in our codebase.

Depends on D4914

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13792

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8880
Build 15735: Default Diff Build & Tests
Build 15734: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 12 2020, 16:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 12 2020, 16:31

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4916: test: add "diamond" unit test to MempoolAncestryTests.Jan 12 2020, 16:33

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8880: Diff 15363.Jan 12 2020, 16:48

Ah fantastic, I was planning to do this at some point. Please fix rebase conflict (D4898 landed) but otherwise looks good, also include make bench-bitcoin (or whatever) in the test plan just to make sure that compiles too.

This revision now requires changes to proceed.Jan 13 2020, 01:17

rebase and merge conflict. Run the benchmarks

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8886: Diff 15380.Jan 13 2020, 02:06

markblundeberg accepted this revision.Jan 13 2020, 05:09

This revision is now accepted and ready to land.Jan 13 2020, 05:09

Closed by commit rABC49330c5d3cd2: scripted-diff: Remove unused first argument to addUnchecked (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyJan 13 2020, 12:19

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC49330c5d3cd2: scripted-diff: Remove unused first argument to addUnchecked.

deadalnix added a commit: rSTAGING49330c5d3cd2: scripted-diff: Remove unused first argument to addUnchecked.Apr 7 2020, 22:24