Page MenuHomePhabricator

Fix the abc-p2p-compactblocks when running whith UBSAN
ClosedPublic

Authored by Fabien on Sat, Jan 11, 13:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC82fe6a22e7ce: Fix the abc-p2p-compactblocks when running whith UBSAN
Summary

UBSAN causes the functional test abc-p2p-compactblocks to timeout, but
it does not exhibit undefined behavior (no output from the sanitizer).
Increasing the RPC timeout fixes the issue.

Test Plan
cmake -GNinja .. \
  -DCMAKE_BUILD_TYPE=Debug \
  -DENABLE_SANITIZERS=undefined \
  -DCCACHE=OFF \
  -DCMAKE_C_COMPILER=clang \
  -DCMAKE_CXX_COMPILER=clang++
ninja
mkdir -p /tmp/sanitizer_logs
export UBSAN_OPTIONS="suppressions=../test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:log_path=/tmp/sanitizer_logs/ubsan.log"
./test/functional/test_runner.py abc-p2p-compactblocks

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Sat, Jan 11, 13:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Jan 11, 13:54
deadalnix accepted this revision.Sat, Jan 11, 14:21
This revision is now accepted and ready to land.Sat, Jan 11, 14:21
This revision was automatically updated to reflect the committed changes.