Page MenuHomePhabricator
Differential D4901

Fix the abc-p2p-compactblocks when running whith UBSAN
ClosedPublic
Actions

Authored by Fabien on Jan 11 2020, 13:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING82fe6a22e7ce: Fix the abc-p2p-compactblocks when running whith UBSAN
rABC82fe6a22e7ce: Fix the abc-p2p-compactblocks when running whith UBSAN
Summary

UBSAN causes the functional test abc-p2p-compactblocks to timeout, but
it does not exhibit undefined behavior (no output from the sanitizer).
Increasing the RPC timeout fixes the issue.

Test Plan
cmake -GNinja .. \
  -DCMAKE_BUILD_TYPE=Debug \
  -DENABLE_SANITIZERS=undefined \
  -DCCACHE=OFF \
  -DCMAKE_C_COMPILER=clang \
  -DCMAKE_CXX_COMPILER=clang++
ninja
mkdir -p /tmp/sanitizer_logs
export UBSAN_OPTIONS="suppressions=../test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:log_path=/tmp/sanitizer_logs/ubsan.log"
./test/functional/test_runner.py abc-p2p-compactblocks

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 11 2020, 13:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2020, 13:54
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 11 2020, 13:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 11 2020, 13:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8858: Diff 15337.Jan 11 2020, 13:59
teamcity added a comment.Jan 11 2020, 14:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 11 2020, 14:05

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Jan 11 2020, 14:21
This revision is now accepted and ready to land.Jan 11 2020, 14:21
Closed by commit rABC82fe6a22e7ce: Fix the abc-p2p-compactblocks when running whith UBSAN (authored by Fabien). · Explain WhyJan 13 2020, 07:12
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC82fe6a22e7ce: Fix the abc-p2p-compactblocks when running whith UBSAN.
Fabien added a commit: rSTAGING82fe6a22e7ce: Fix the abc-p2p-compactblocks when running whith UBSAN.Apr 7 2020, 22:24

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
2 lines
test/
functional/
2 lines

Diff 15384

View Options

contrib/teamcity/build-configurations.sh

Loading...
View Options

test/functional/abc-p2p-compactblocks.py

Loading...