Page MenuHomePhabricator

Fix the abc-p2p-compactblocks when running whith UBSAN
ClosedPublic

Authored by Fabien on Jan 11 2020, 13:54.

Details

Summary

UBSAN causes the functional test abc-p2p-compactblocks to timeout, but
it does not exhibit undefined behavior (no output from the sanitizer).
Increasing the RPC timeout fixes the issue.

Test Plan
cmake -GNinja .. \
  -DCMAKE_BUILD_TYPE=Debug \
  -DENABLE_SANITIZERS=undefined \
  -DCCACHE=OFF \
  -DCMAKE_C_COMPILER=clang \
  -DCMAKE_CXX_COMPILER=clang++
ninja
mkdir -p /tmp/sanitizer_logs
export UBSAN_OPTIONS="suppressions=../test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:log_path=/tmp/sanitizer_logs/ubsan.log"
./test/functional/test_runner.py abc-p2p-compactblocks

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_abc_p2p_compactblock_ubsan
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8858
Build 15691: Default Diff Build & Tests
Build 15690: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 11 2020, 14:21