Mark CTxMemPoolEntry members that should not be modified const
ClosedPublic
Actions

Authored by deadalnix on Jan 12 2020, 16:27.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGdbc0fc6462a4: Mark CTxMemPoolEntry members that should not be modified const
rABCdbc0fc6462a4: Mark CTxMemPoolEntry members that should not be modified const

Summary

This is a partial backport of Core PR13792 : https://github.com/bitcoin/bitcoin/pull/13792/commits/ddd395f968a050be5dd0ae21ba7d189b6b7f73fd

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13792-0

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8879
Build 15733: Default Diff Build & Tests
Build 15732: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 12 2020, 16:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 12 2020, 16:27

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4915: scripted-diff: Remove unused first argument to addUnchecked.Jan 12 2020, 16:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8879: Diff 15362.Jan 12 2020, 16:34

markblundeberg accepted this revision.Jan 13 2020, 01:13

This revision is now accepted and ready to land.Jan 13 2020, 01:13

Closed by commit rABCdbc0fc6462a4: Mark CTxMemPoolEntry members that should not be modified const (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyJan 13 2020, 01:30

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCdbc0fc6462a4: Mark CTxMemPoolEntry members that should not be modified const.

deadalnix added a commit: rSTAGINGdbc0fc6462a4: Mark CTxMemPoolEntry members that should not be modified const.Apr 7 2020, 22:24

Revision Contents
Changeset List

Path

Size

src/

txmempool.h

16 lines

txmempool.cpp

10 lines

Diff 15362

View Options

src/txmempool.h