Page MenuHomePhabricator

[wallet] Support creating a blank wallet
ClosedPublic

Authored by deadalnix on Mon, Jan 13, 12:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbe651fb90eb6: [wallet] Support creating a blank wallet
Summary

A blank wallet is a wallet that has no keys, script or watch only things.
A new wallet flag indicating that it is blank will be set when the wallet
is blank. Once it is no longer blank (a seed has been generated, keys or
scripts imported, etc), the flag will be unset.

This is a backport of Core PR15226

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Mon, Jan 13, 12:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jan 13, 12:47
deadalnix updated this revision to Diff 15395.Mon, Jan 13, 13:05

Fix integration test which wa spartially erroneously commented

Fabien requested changes to this revision.Mon, Jan 13, 15:29
Fabien added a subscriber: Fabien.

The release notes needs to be updated.

doc/release-notes-15226.md
6 ↗(On Diff #15395)

I suppose this version number has to be adapted.

7 ↗(On Diff #15395)

Dito.

src/wallet/wallet.h
1374 ↗(On Diff #15395)

Fix layout.

test/functional/test_runner.py
80 ↗(On Diff #15395)

Missing "wallet_createwallet.py": [["--usecli"]],

test/functional/timing.json
385 ↗(On Diff #15395)

Please add wallet_createwallet.py and wallet_createwallet.py -usecli

test/functional/wallet_createwallet.py
21 ↗(On Diff #15395)

Note to reviewers: this is not yet in use in our codebase, but it's fine to have it ready for the time the feature is backported.

26 ↗(On Diff #15395)

Move comment on its own line.

This revision now requires changes to proceed.Mon, Jan 13, 15:29
deadalnix added inline comments.Mon, Jan 13, 16:31
doc/release-notes-15226.md
7 ↗(On Diff #15395)

Let's just move this in the release notes.

deadalnix updated this revision to Diff 15407.Mon, Jan 13, 16:51

Redo release notes

Fabien requested changes to this revision.Tue, Jan 14, 10:01

Clearing my queue, waiting for other comments to be addressed.

This revision now requires changes to proceed.Tue, Jan 14, 10:01
deadalnix updated this revision to Diff 15443.Tue, Jan 14, 12:55

Address comments

deadalnix added inline comments.Tue, Jan 14, 13:02
test/functional/timing.json
385 ↗(On Diff #15395)

What if we had a system that run the tests on a regular basis, and therefore know the timing very well, and therefore could not only fill this file is way more accurate and consistent values, but it could do so 100% automatically.

Fabien accepted this revision.Tue, Jan 14, 13:22
Fabien added inline comments.
test/functional/wallet_createwallet.py
26 ↗(On Diff #15443)

There is a tab missing here

This revision is now accepted and ready to land.Tue, Jan 14, 13:22
This revision was automatically updated to reflect the committed changes.