Page MenuHomePhabricator

[wallet] Support creating a blank wallet
ClosedPublic

Authored by deadalnix on Jan 13 2020, 12:47.

Details

Summary

A blank wallet is a wallet that has no keys, script or watch only things.
A new wallet flag indicating that it is blank will be set when the wallet
is blank. Once it is no longer blank (a seed has been generated, keys or
scripts imported, etc), the flag will be unset.

This is a backport of Core PR15226

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15226
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8927
Build 15828: Default Diff Build & Tests
Build 15827: arc lint + arc unit

Event Timeline

Fix integration test which wa spartially erroneously commented

Fabien requested changes to this revision.Jan 13 2020, 15:29
Fabien added a subscriber: Fabien.

The release notes needs to be updated.

doc/release-notes-15226.md
6 ↗(On Diff #15395)

I suppose this version number has to be adapted.

7 ↗(On Diff #15395)

Dito.

src/wallet/wallet.h
1374 ↗(On Diff #15395)

Fix layout.

test/functional/test_runner.py
80 ↗(On Diff #15395)

Missing "wallet_createwallet.py": [["--usecli"]],

test/functional/timing.json
385 ↗(On Diff #15395)

Please add wallet_createwallet.py and wallet_createwallet.py -usecli

test/functional/wallet_createwallet.py
21 ↗(On Diff #15395)

Note to reviewers: this is not yet in use in our codebase, but it's fine to have it ready for the time the feature is backported.

26 ↗(On Diff #15395)

Move comment on its own line.

This revision now requires changes to proceed.Jan 13 2020, 15:29
doc/release-notes-15226.md
7 ↗(On Diff #15395)

Let's just move this in the release notes.

Fabien requested changes to this revision.Jan 14 2020, 10:01

Clearing my queue, waiting for other comments to be addressed.

This revision now requires changes to proceed.Jan 14 2020, 10:01
test/functional/timing.json
385 ↗(On Diff #15395)

What if we had a system that run the tests on a regular basis, and therefore know the timing very well, and therefore could not only fill this file is way more accurate and consistent values, but it could do so 100% automatically.

Fabien added inline comments.
test/functional/wallet_createwallet.py
26

There is a tab missing here

This revision is now accepted and ready to land.Jan 14 2020, 13:22