Page MenuHomePhabricator
Differential D4921

[wallet] Support creating a blank wallet
ClosedPublic
Actions

Authored by deadalnix on Jan 13 2020, 12:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGbe651fb90eb6: [wallet] Support creating a blank wallet
rABCbe651fb90eb6: [wallet] Support creating a blank wallet
Summary

A blank wallet is a wallet that has no keys, script or watch only things.
A new wallet flag indicating that it is blank will be set when the wallet
is blank. Once it is no longer blank (a seed has been generated, keys or
scripts imported, etc), the flag will be unset.

This is a backport of Core PR15226

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15226
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8895
Build 15765: Default Diff Build & Tests
Build 15764: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 13 2020, 12:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2020, 12:47
teamcity added a comment.Jan 13 2020, 12:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix updated this revision to Diff 15395.Jan 13 2020, 13:05

Fix integration test which wa spartially erroneously commented

teamcity added a comment.Jan 13 2020, 13:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 13 2020, 13:12

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8895: Diff 15395.Jan 13 2020, 13:12
teamcity added a comment.Jan 13 2020, 13:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8893: Diff 15393.Jan 13 2020, 13:13
Fabien requested changes to this revision.Jan 13 2020, 15:29
Fabien added a subscriber: Fabien.

The release notes needs to be updated.

doc/release-notes-15226.md
6

I suppose this version number has to be adapted.

7

Dito.

src/wallet/wallet.h
1374

Fix layout.

test/functional/test_runner.py
80

Missing "wallet_createwallet.py": [["--usecli"]],

test/functional/timing.json
385

Please add wallet_createwallet.py and wallet_createwallet.py -usecli

test/functional/wallet_createwallet.py
21

Note to reviewers: this is not yet in use in our codebase, but it's fine to have it ready for the time the feature is backported.

26

Move comment on its own line.

This revision now requires changes to proceed.Jan 13 2020, 15:29
deadalnix added inline comments.Jan 13 2020, 16:31
doc/release-notes-15226.md
7

Let's just move this in the release notes.

deadalnix updated this revision to Diff 15407.Jan 13 2020, 16:51

Redo release notes

teamcity added a comment.Jan 13 2020, 16:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 13 2020, 16:58

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8903: Diff 15407.Jan 13 2020, 16:58
Fabien requested changes to this revision.Jan 14 2020, 10:01

Clearing my queue, waiting for other comments to be addressed.

This revision now requires changes to proceed.Jan 14 2020, 10:01
deadalnix updated this revision to Diff 15443.Jan 14 2020, 12:55

Address comments

teamcity added a comment.Jan 14 2020, 12:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 14 2020, 13:02

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8927: Diff 15443.Jan 14 2020, 13:02
deadalnix added inline comments.Jan 14 2020, 13:02
test/functional/timing.json
385

What if we had a system that run the tests on a regular basis, and therefore know the timing very well, and therefore could not only fill this file is way more accurate and consistent values, but it could do so 100% automatically.

Fabien accepted this revision.Jan 14 2020, 13:22
Fabien added inline comments.
test/functional/wallet_createwallet.py
26 ↗(On Diff #15443)

There is a tab missing here

This revision is now accepted and ready to land.Jan 14 2020, 13:22
Closed by commit rABCbe651fb90eb6: [wallet] Support creating a blank wallet (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJan 14 2020, 13:25
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCbe651fb90eb6: [wallet] Support creating a blank wallet.
deadalnix added a commit: rSTAGINGbe651fb90eb6: [wallet] Support creating a blank wallet.Apr 7 2020, 22:26

Revision Contents
Changeset List

PathSize
doc/
8 lines
src/
interfaces/
3 lines
1 line
qt/
10 lines
rpc/
1 line
wallet/
3 lines
36 lines
test/
1 line
26 lines
79 lines
test/
functional/
1 line
8 lines
127 lines

Diff 15395

View Options

doc/release-notes-15226.md

Loading...
View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/wallet/crypter.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/test_runner.py

Loading...
View Options

test/functional/timing.json

Loading...
View Options

test/functional/wallet_createwallet.py

Loading...
View Options

test/functional/wallet_disableprivatekeys.py

Loading...