Since cmake 3.8.2, the -fPIE flag is managed by cmake and added to the
compilation flags if POSITION_INDEPENDENT_CODE is ON. Adding it
manually is redundant at most, and error prone at worst.
Note that the -pie linker flag still needs to be added manually until
cmake 3.14+ is enforced.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING7c1f0ab29538: [CMAKE] Remove extra -fPIE flag
rABC7c1f0ab29538: [CMAKE] Remove extra -fPIE flag
# You may need to clear your ccache cmake -GNinja .. ninja check-security
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cmake_remove_extra_fpie
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8958 Build 15889: Default Diff Build & Tests Build 15888: arc lint + arc unit