[CMAKE] Remove useless remove_compile_flag in leveldb
ClosedPublic
Actions

Authored by Fabien on Jan 16 2020, 09:03.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING784629a8ed62: [CMAKE] Remove useless remove_compile_flag in leveldb
rABC784629a8ed62: [CMAKE] Remove useless remove_compile_flag in leveldb

Summary

LevelDB adds a -Wno-strict-prototypes then removes
-Wstrict-prototypes. This is redundant and does not work anymore since
it tries to remove the flag from the CFLAGS which are no longer used
for this purpose since D4947.

Test Plan

cmake -GNinja .. -DCMAKE_C_FLAGS="-Werror=strict-prototypes"
ninja check-leveldb

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 16 2020, 09:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2020, 09:03

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8976: Diff 15516.Jan 16 2020, 09:20

jasonbcox accepted this revision.Jan 16 2020, 16:46

This revision is now accepted and ready to land.Jan 16 2020, 16:46

Closed by commit rABC784629a8ed62: [CMAKE] Remove useless remove_compile_flag in leveldb (authored by Fabien). · Explain WhyJan 16 2020, 20:08

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC784629a8ed62: [CMAKE] Remove useless remove_compile_flag in leveldb.

Fabien added a commit: rSTAGING784629a8ed62: [CMAKE] Remove useless remove_compile_flag in leveldb.Apr 7 2020, 22:28

Revision Contents
Changeset List

Path

Size

src/

leveldb/

CMakeLists.txt

1 line

Diff 15527

View Options

src/leveldb/CMakeLists.txt

[CMAKE] Remove useless remove_compile_flag in leveldbClosedPublicActions