Page MenuHomePhabricator

[CMAKE] Remove useless remove_compile_flag in leveldb
ClosedPublic

Authored by Fabien on Jan 16 2020, 09:03.

Details

Summary

LevelDB adds a -Wno-strict-prototypes then removes
-Wstrict-prototypes. This is redundant and does not work anymore since
it tries to remove the flag from the CFLAGS which are no longer used
for this purpose since D4947.

Test Plan
cmake -GNinja .. -DCMAKE_C_FLAGS="-Werror=strict-prototypes"
ninja check-leveldb

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_remove_compiler_flag_leveldb
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8976
Build 15917: Default Diff Build & Tests
Build 15916: arc lint + arc unit