Page MenuHomePhabricator
Differential D4985

Add trivial ecmult_multi algorithm which does not require a scratch space
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2020, 12:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING69b03d6352c8: Add trivial ecmult_multi algorithm which does not require a scratch space
rABC69b03d6352c8: Add trivial ecmult_multi algorithm which does not require a scratch space
Summary
  • Add trivial ecmult_multi algorithm. It is selected when no scratch space is given and just multiplies and adds the points.
  • Add trivial ecmult_multi to the benchmark tool

This is a backport of secp256k1's PR580

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 17 2020, 12:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 12:05
deadalnix added a child revision: D4987: Fix integer overflow in ecmult_multi_var when n is large.Jan 17 2020, 12:13
Fabien accepted this revision.Jan 17 2020, 13:28
This revision is now accepted and ready to land.Jan 17 2020, 13:28
teamcity added a comment.Jan 17 2020, 14:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

This revision was landed with ongoing or failed builds.Jan 17 2020, 14:08
Closed by commit rABC69b03d6352c8: Add trivial ecmult_multi algorithm which does not require a scratch space (authored by Jonas Nick <jonasd.nick@gmail.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC69b03d6352c8: Add trivial ecmult_multi algorithm which does not require a scratch space.
teamcity added a comment.Jan 17 2020, 14:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9008: Diff 15572.Jan 17 2020, 14:14
deadalnix added a commit: rSTAGING69b03d6352c8: Add trivial ecmult_multi algorithm which does not require a scratch space.Apr 7 2020, 22:30

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
18 lines
3 lines
30 lines
1 line

Diff 15587

View Options

src/secp256k1/src/bench_ecmult.c

Loading...
View Options

src/secp256k1/src/ecmult.h

Loading...
View Options

src/secp256k1/src/ecmult_impl.h

Loading...
View Options

src/secp256k1/src/tests.c

Loading...