Page MenuHomePhabricator
Differential D5006

[CMAKE] Fix daemon() detection on OSX
ClosedPublic
Actions

Authored by Fabien on Jan 17 2020, 20:34.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING56a37f9d7cb5: [CMAKE] Fix daemon() detection on OSX
rABC56a37f9d7cb5: [CMAKE] Fix daemon() detection on OSX
Summary

On BSDs and macOS, the daemon() function is located in stdlib.h.

Test Plan

On OSX:

cmake -GNinja ..

Check daemon is found.

ninja
./src/bitcoind -daemon

Check the argument is supported and works as expected.

Run the OSX Gitian build and test the -daemon option is supported on
the produced bitcoind binary.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 17 2020, 20:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 20:34
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 17 2020, 20:34

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 17 2020, 20:38

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jan 17 2020, 20:42

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Fabien added a comment.Jan 17 2020, 20:45

I tested the binary from the Gitian build and it doesn't have the issue.

jasonbcox accepted this revision.Jan 17 2020, 20:46
This revision is now accepted and ready to land.Jan 17 2020, 20:46
teamcity added a comment.Jan 17 2020, 20:51

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9033: Diff 15622.Jan 17 2020, 20:51
Closed by commit rABC56a37f9d7cb5: [CMAKE] Fix daemon() detection on OSX (authored by Fabien). · Explain WhyJan 17 2020, 21:01
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC56a37f9d7cb5: [CMAKE] Fix daemon() detection on OSX.
Fabien added a commit: rSTAGING56a37f9d7cb5: [CMAKE] Fix daemon() detection on OSX.Apr 7 2020, 22:33

Revision Contents
Changeset List

PathSize
src/
config/
3 lines

Diff 15623

View Options

src/config/CMakeLists.txt

Loading...