[CMAKE] Fix getentropy detection on OSX
ClosedPublic
Actions

Authored by Fabien on Jan 17 2020, 21:37.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX
rABC0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX

Summary

OSX needs both unistd.h and sys/random.h in order to define
getentropy().

Test Plan

On OSX:

cmake -GNinja ..

Check the first getentropy (only unistd.h) fails, and the second one
(both unistd.h and sys/random.h) succeeds.

Run the OSX gitian build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 17 2020, 21:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 21:37

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix accepted this revision.Jan 17 2020, 21:40

This revision is now accepted and ready to land.Jan 17 2020, 21:40

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9034: Diff 15624.Jan 17 2020, 21:43

jasonbcox accepted this revision.Jan 17 2020, 21:45

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Closed by commit rABC0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX (authored by Fabien). · Explain WhyJan 17 2020, 21:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX.

Fabien added a commit: rSTAGING0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX.Apr 7 2020, 22:33

Revision Contents
Changeset List

Path

Size

src/

config/

CMakeLists.txt

3 lines

Diff 15625

View Options

[CMAKE] Fix getentropy detection on OSXClosedPublicActions