Page MenuHomePhabricator
Differential D5007

[CMAKE] Fix getentropy detection on OSX
ClosedPublic
Actions

Authored by Fabien on Jan 17 2020, 21:37.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX
rABC0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX
Summary

OSX needs both unistd.h and sys/random.h in order to define
getentropy().

Test Plan

On OSX:

cmake -GNinja ..

Check the first getentropy (only unistd.h) fails, and the second one
(both unistd.h and sys/random.h) succeeds.

Run the OSX gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_getentropy_osx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9034
Build 16030: Default Diff Build & Tests
Build 16029: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 17 2020, 21:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 21:37
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 17 2020, 21:37

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix accepted this revision.Jan 17 2020, 21:40
This revision is now accepted and ready to land.Jan 17 2020, 21:40
teamcity added a comment.Jan 17 2020, 21:43

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jan 17 2020, 21:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9034: Diff 15624.Jan 17 2020, 21:43
jasonbcox accepted this revision.Jan 17 2020, 21:45
teamcity added a comment.Jan 17 2020, 21:47

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Closed by commit rABC0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX (authored by Fabien). · Explain WhyJan 17 2020, 21:48
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX.
Fabien added a commit: rSTAGING0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX.Apr 7 2020, 22:33

Revision Contents
Changeset List

PathSize
src/
config/
3 lines

Diff 15624

View Options

src/config/CMakeLists.txt

Loading...