Page MenuHomePhabricator

Increase RPC timeout for the feature_assumevalid test
ClosedPublic

Authored by Fabien on Jan 21 2020, 14:58.

Details

Summary

This is expected to avoid flakiness when it runs with TSAN.

Test Plan

With TSAN:

./test/functional/test_runner.py feature_assumevalid.

Run the TSAN build on CI.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien planned changes to this revision.Jan 21 2020, 15:00

Need to run the TSAN build a few times to see if the fix is working, since I cannot reproduce locally.

Fabien requested review of this revision.Jan 21 2020, 18:15

Requesting review since I can't make the test to fail. That doesn't mean that it works, but at least gives some confidence.

Fabien retitled this revision from [WIP] Increase RPC timeout for the feature_assumevalid test to Increase RPC timeout for the feature_assumevalid test.Jan 22 2020, 15:23
This revision is now accepted and ready to land.Jan 22 2020, 16:36