Page MenuHomePhabricator
Differential D5039

Increase RPC timeout for the feature_assumevalid test
ClosedPublic
Actions

Authored by Fabien on Jan 21 2020, 14:58.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING9b9bfc718f0b: Increase RPC timeout for the feature_assumevalid test
rABC9b9bfc718f0b: Increase RPC timeout for the feature_assumevalid test
Summary

This is expected to avoid flakiness when it runs with TSAN.

Test Plan

With TSAN:

./test/functional/test_runner.py feature_assumevalid.

Run the TSAN build on CI.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_feature_assumevalid_tsan_timeout
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9097
Build 16156: Default Diff Build & Tests
Build 16155: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 21 2020, 14:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2020, 14:58
Herald added a reviewer: deadalnix. · View Herald Transcript
Fabien planned changes to this revision.Jan 21 2020, 15:00

Need to run the TSAN build a few times to see if the fix is working, since I cannot reproduce locally.

teamcity added a comment.Jan 21 2020, 15:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 21 2020, 15:11

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 21 2020, 15:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9097: Diff 15717.Jan 21 2020, 15:19
teamcity added a comment.Jan 21 2020, 15:20

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

teamcity added a comment.Jan 21 2020, 15:33

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 21 2020, 15:41

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

teamcity added a comment.Jan 21 2020, 16:13

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 21 2020, 16:13

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 21 2020, 16:21

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

teamcity added a comment.Jan 21 2020, 16:21

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 21 2020, 16:21

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

teamcity added a comment.Jan 21 2020, 16:27

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 21 2020, 16:30

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

teamcity added a comment.Jan 21 2020, 16:30

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 21 2020, 16:36

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

teamcity added a comment.Jan 21 2020, 16:38

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

teamcity added a comment.Jan 21 2020, 16:47

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 21 2020, 16:47

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 21 2020, 16:56

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

teamcity added a comment.Jan 21 2020, 16:56

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 21 2020, 16:56

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

teamcity added a comment.Jan 21 2020, 17:04

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Fabien requested review of this revision.Jan 21 2020, 18:15

Requesting review since I can't make the test to fail. That doesn't mean that it works, but at least gives some confidence.

Fabien retitled this revision from [WIP] Increase RPC timeout for the feature_assumevalid test to Increase RPC timeout for the feature_assumevalid test.Jan 22 2020, 15:23
jasonbcox accepted this revision.Jan 22 2020, 16:36
This revision is now accepted and ready to land.Jan 22 2020, 16:36
Closed by commit rABC9b9bfc718f0b: Increase RPC timeout for the feature_assumevalid test (authored by Fabien). · Explain WhyJan 22 2020, 20:40
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC9b9bfc718f0b: Increase RPC timeout for the feature_assumevalid test.
Fabien added a commit: rSTAGING9b9bfc718f0b: Increase RPC timeout for the feature_assumevalid test.Apr 7 2020, 22:37

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines

Diff 15717

View Options

test/functional/feature_assumevalid.py

Loading...