Page MenuHomePhabricator
Differential D5062

split abc-p2p-fullblocktest into sigops and non-sigops parts
ClosedPublic
Actions

Authored by markblundeberg on Jan 24 2020, 14:12.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T704: sigChecks implementation
Commits
rSTAGING5c8e48c0054f: split abc-p2p-fullblocktest into sigops and non-sigops parts
rABC5c8e48c0054f: split abc-p2p-fullblocktest into sigops and non-sigops parts
Summary

Like with D5060, it makes sense to split out the sigops part of
this test since we're planning to deactivate sigops, and this lets
us independently deal with sigops.

Test Plan

ninja check-extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
split_abcfullblocktest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9138
Build 16234: Default Diff Build & Tests
Build 16233: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 24 2020, 14:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2020, 14:12
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 24 2020, 14:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a child revision: D5029: deactivate sigops limits in phonon upgrade.Jan 24 2020, 14:14
teamcity added a comment.Jan 24 2020, 14:16

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9130: Diff 15771.Jan 24 2020, 14:16
deadalnix requested changes to this revision.Jan 25 2020, 13:21
deadalnix added inline comments.
test/functional/abc-p2p-fullblocktest-sigops.py
1 ↗(On Diff #15771)

You need to chmod this.

This revision now requires changes to proceed.Jan 25 2020, 13:21
markblundeberg added inline comments.Jan 26 2020, 03:18
test/functional/abc-p2p-fullblocktest-sigops.py
1 ↗(On Diff #15771)

oh, good catch!

markblundeberg updated this revision to Diff 15788.Jan 26 2020, 03:22

chmod

teamcity added a comment.Jan 26 2020, 03:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 26 2020, 03:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9138: Diff 15788.Jan 26 2020, 03:27
deadalnix accepted this revision.Jan 27 2020, 01:00
This revision is now accepted and ready to land.Jan 27 2020, 01:00
Closed by commit rABC5c8e48c0054f: split abc-p2p-fullblocktest into sigops and non-sigops parts (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyJan 27 2020, 04:19
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC5c8e48c0054f: split abc-p2p-fullblocktest into sigops and non-sigops parts.
markblundeberg added a task: T704: sigChecks implementation.Jan 27 2020, 04:31
markblundeberg added a child revision: D5076: make per-tx sigops limit contextual.Jan 27 2020, 11:23
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING5c8e48c0054f: split abc-p2p-fullblocktest into sigops and non-sigops parts.Apr 7 2020, 22:38

Revision Contents
Changeset List

PathSize
test/
functional/
abc-p2p-fullblocktest-sigops.py
abc-p2p-fullblocktest.py
54 lines
163 lines

Diff 15788

View Options

test/functional/abc-p2p-fullblocktest-sigops.py

Loading...
View Options

test/functional/abc-p2p-fullblocktest.py

Loading...