Page MenuHomePhabricator

Revert "move ScriptExecutionMetrics to its own file"
Changes PlannedPublic

Authored by markblundeberg on Jan 25 2020, 04:21.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T704: sigChecks implementation
Summary

This reverts commit 8dc344a1d63dae6f1d6b7960cf77a85301cc175d (D5065)

It appears it will only be necessarily for callers of EvalScript /
VerifyScript to use this struct (which just results), so its original
location made more sense.

Depends on D5065

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
revrev
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9136
Build 16230: Bitcoin ABC Buildbot
Build 16229: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 25 2020, 04:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2020, 04:21

I do not think this was a bad move. You'll need a TxMetrics and a BlockMetrics type and both will use ScriptExecutionMetrics in some way, but not the rest of interpreter.h .

markblundeberg planned changes to this revision.Jan 30 2020, 10:23

OK we can do these later...