Revert "move ScriptExecutionMetrics to its own file"
Changes PlannedPublic
Actions

Authored by markblundeberg on Jan 25 2020, 04:21.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

T704: sigChecks implementation

Summary

This reverts commit 8dc344a1d63dae6f1d6b7960cf77a85301cc175d (D5065)

It appears it will only be necessarily for callers of EvalScript /
VerifyScript to use this struct (which just results), so its original
location made more sense.

Depends on D5065

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

revrev

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9136
Build 16230: Default Diff Build & Tests
Build 16229: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 25 2020, 04:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2020, 04:21

Herald added a reviewer: deadalnix. · View Herald Transcript

markblundeberg added a task: T704: sigChecks implementation.Jan 25 2020, 04:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9136: Diff 15784.Jan 25 2020, 04:39

I do not think this was a bad move. You'll need a TxMetrics and a BlockMetrics type and both will use ScriptExecutionMetrics in some way, but not the rest of interpreter.h .