Page MenuHomePhabricator
Differential D5069

FinalizeBlockAndInvalidate: just use chainActive
ClosedPublic
Actions

Authored by markblundeberg on Jan 26 2020, 08:15.

Details

Reviewers
fpelliccioni
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING02caabba2898: FinalizeBlockAndInvalidate: just use chainActive
rABC02caabba2898: FinalizeBlockAndInvalidate: just use chainActive
Summary

Generally we're better off using the chainActive random access vector
than using the CBlockIndex linked lists, whenever we can.

Bonus: correctly handle the case when pindex is a child of Tip (i.e.,
when pindexFork == Tip), where it's not needed to invalidate anything.
Not sure why that would ever happen but why not do it right...

Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jan 26 2020, 08:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 26 2020, 08:16
teamcity added a comment.Jan 26 2020, 08:16

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a reviewer: deadalnix.Jan 26 2020, 08:18
teamcity added a comment.Jan 26 2020, 08:20

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9143: Diff 15793.Jan 26 2020, 08:20
deadalnix accepted this revision.Jan 27 2020, 16:46

If the index is a child of tip, shouldn't we invalidate its siblings?

In any case, I'm not sure it matters much.

This revision is now accepted and ready to land.Jan 27 2020, 16:46
Closed by commit rABC02caabba2898: FinalizeBlockAndInvalidate: just use chainActive (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyJan 28 2020, 11:53
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC02caabba2898: FinalizeBlockAndInvalidate: just use chainActive.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING02caabba2898: FinalizeBlockAndInvalidate: just use chainActive.Apr 7 2020, 22:40

Revision Contents
Changeset List

PathSize
src/
11 lines

Diff 15835

View Options

src/validation.cpp

Loading...