Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers
ClosedPublic
Actions

Authored by freetrader on Aug 30 2017, 10:00.

Details

Reviewers

deadalnix
CCulianu

Group Reviewers

Restricted Project

Commits

rSTAGING1b983a1986dc: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers
rABC1b983a1986dc: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers

Summary

The OSX property list MIME type application/x-bitcoin-payment-request
is renamed to application/bitcoincash-paymentrequest in line with previous
changes in the wallet. This type is associated with .bitcoinpaymentrequest
files.

The identifiers used in the property list and payment protocol definition
file are updated to 'bitcoincash' to differentiate, and a few comments are
modified to reflect Bitcoin Cash.

No extensions of the existing payment protocol seem to have been
registered at the indicated Wiki URL, so the registration point has
been made into a TODO pending a decision on where such registrations
could occur.

This issue is marked as WIP pending review and confirmation of successful
tests.

Test Plan

make check (on wallet build)
../qa/pull-tester/rpc-tests.py -extended

Gitian builds
Travis builds

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mime_type_updates

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 795
Build 795: arc lint + arc unit

Event Timeline

freetrader created this revision.Aug 30 2017, 10:00

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptAug 30 2017, 10:00

Harbormaster completed remote builds in B795: Diff 1274.Aug 30 2017, 10:00

Gitian builds and the extended tests worked alright.
Travis testing seems blocked by a hanging test on HEAD at the moment - I'll push this on a branch off the last passing commit to test.

Travis test passed:
https://travis-ci.org/ftrader-bitcoinabc/bitcoin-abc/builds/269961272

freetrader retitled this revision from [WIP] Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers to Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers.Aug 30 2017, 13:35

A few comments. Otherwise looks good to me.

share/qt/Info.plist.in
32	FYI this reminds me -- currently we build "Bitcoin-Qt.app" on the mac, with the executable being called Bitcoin-Qt. I think we should rename the Mac app to BitcoinABC-Qt. (and of course modify this Info.plist.in accordingly). Having it have the same name as Bitcoin-Qt (core) will be annoying as fuck to users. I run a Mac and I know it would annoy me. Because that means I can't install both in the standard place on Macs: /Applications. We don't even have to change much -- just the app bundle name (".app") that gets produced. I can help you do that -- if you don't feel like worrying about it. I have a mac and can quickly test this. Let me know!
52	url scheme should probably be bitoincash in line with the other changes in src/qt/paymentserver.cpp, etc. I think you probably just missed this one. :)

freetrader added inline comments.Aug 30 2017, 13:56

share/qt/Info.plist.in
32	I looked at this name and saw it in other areas, so would rather do this as a separate change. I agree with you we should get ABC in there.
52	Yes, indeed this one slipped thru - will fix, thanks!