Page MenuHomePhabricator

[Review ONLY] Migrate bitcoinabc.org codebase into the ABC repo
AbandonedPublic

Authored by jasonbcox on Jan 31 2020, 19:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This diff is for review purposes only. In order to preserve history, I will need to land
these commits via git push rather than arc land.

Note the files will be located at /web at the top level of the project.

Pulling in these commits will allow us to get better review on bitcoinabc.org improvements as well as build on our existing automation. Some examples of improvements coming down the pipe:

  • Reducing bitcoinabc.org deployment times from 10-15 minutes to ~5 seconds.
  • Reduced reliance on current hosting infra which, for reasons I won't go into here, is not viable for us in a few months.
  • Start linting web files (where appropriate).
  • Release automation can post release notes to the website. This is an item that has been requested by multiple parties over the years.

Note that George is working on improving the blog, which may include some of the reworkings that @deadalnix mentioned below. We need these improvements, but lack of dev resources makes it infeasible to tackle this all in one go prior to this migration.

Test Plan

Follow build instructions in README

Diff Detail

Repository
rABC Bitcoin ABC
Branch
abcorg-s-mv_web
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningweb/_posts/2018-01-14-CashAddr-es.md:46SPELL1Possible Spelling Mistake
Warningweb/_posts/2018-04-01-upgrade-es.md:23SPELL1Possible Spelling Mistake
Warningweb/_posts/2018-05-07-incident-report-es.md:25SPELL1Possible Spelling Mistake
Warningweb/_posts/2018-05-07-incident-report-es.md:27SPELL1Possible Spelling Mistake
Auto-Fixweb/_config-dev.yml:79WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_config-prod.yml:79WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_config.yml:79WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2017-11-01-DAA.md:9WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2017-11-01-DAA.md:21WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2017-11-01-DAA.md:37WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-01-14-CashAddr.md:3WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-01-14-CashAddr.md:9WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-01-14-CashAddr.md:13WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-01-14-CashAddr.md:28WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-01-14-CashAddr.md:38WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-01-14-CashAddr.md:72WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-01-14-CashAddr.md:78WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-04-01-upgrade.md:10WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-04-01-upgrade.md:12WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-04-01-upgrade.md:37WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-05-07-incident-report.md:4WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-07-05-nov-hardfork-timeline.md:9WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-07-05-nov-hardfork-timeline.md:13WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-07-05-nov-hardfork-timeline.md:15WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/_posts/2018-08-08-nov-code-complete-reminder-es.md:21WHITESPACE1Found trailing whitespace(s).
Unit
No Test Coverage
Build Status
Buildable 10576
Build 18962: Default Diff Build & Tests
Build 18961: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Feb 1 2020, 02:31
deadalnix added a subscriber: deadalnix.

1/ Name it web; www or something.
2/ This needs to reworked. I don't think we want blogs posts in there for instance.

This revision now requires changes to proceed.Feb 1 2020, 02:31

Moved bitcoinabc.org -> web at the top level

2/ This needs to reworked. I don't think we want blogs posts in there for instance.

While this may be true, we don't have a webdev resource to work on this at the moment.
I'm migrating what we have right now so that I can continue working on our deployment
infrastructure and automate the version bumping that we do regularly on the website.

If we want to get rid of the blog-style posts, there are multiple things to consider
that I would rather not shift my focus to at this time. Just off the top of my head:

  • Providing a post archive so the hardlinks still function.
  • Do we move past and future blog posts a designated site or something else?
  • Without the posts/announcements section, the layout of the site is liable to change.

Hmm when you guys described moving the website into the repo I thought it was crazy as I was imagining something much bigger... this seems not so bad!

jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the summary of this revision. (Show Details)
majcosta added inline comments.
web/.gitignore
10

should the contents of the page's .gitignore file be moved to the main repo .gitignore?

web/.gitignore
10

No. Nested .gitignores are not only supported, but also good design. Moving these up to the top-level would put a lot of garbage that does not belong in the top-level.

After a discussion in our team meeting, we decided it's not the right way forward. We'll add the bitcoinabc.org repo to Phab to improve code review and iteration throughput, but the repo itself will remain separate.