Page MenuHomePhabricator
Differential D5125

Fix missing lock in txvalidationcache_tests
ClosedPublic
Actions

Authored by Fabien on Feb 1 2020, 09:24.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Maniphest Tasks
T719: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken.
T720: Build Bitcoin-ABC / Master / Bitcoin-ABC Master UBSAN is broken.
T721: Build Bitcoin-ABC / Master / Bitcoin-ABC Master ASAN is broken.
Commits
rSTAGINGaf65f22e4729: Fix missing lock in txvalidationcache_tests
rABCaf65f22e4729: Fix missing lock in txvalidationcache_tests
Summary

IsKeyInScriptCache() and AddKeyInScriptCache require holding
cs_main.

(bug introduced in D4834)

fixes T719 T720 T721

Test Plan
cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_lock_txvalidationcache_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9224
Build 16393: Default Diff Build & Tests
Build 16392: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 1 2020, 09:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2020, 09:24
teamcity added a comment.Feb 1 2020, 09:25

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 1 2020, 09:29

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9224: Diff 15937.Feb 1 2020, 09:29
markblundeberg accepted this revision.Feb 1 2020, 09:53
This revision is now accepted and ready to land.Feb 1 2020, 09:53
markblundeberg edited the summary of this revision. (Show Details)Feb 1 2020, 09:57
markblundeberg edited the summary of this revision. (Show Details)Feb 1 2020, 10:01
markblundeberg added tasks: T721: Build Bitcoin-ABC / Master / Bitcoin-ABC Master ASAN is broken., T720: Build Bitcoin-ABC / Master / Bitcoin-ABC Master UBSAN is broken., T719: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken..
Closed by commit rABCaf65f22e4729: Fix missing lock in txvalidationcache_tests (authored by Fabien). · Explain WhyFeb 1 2020, 10:33
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCaf65f22e4729: Fix missing lock in txvalidationcache_tests.
Fabien added a commit: rSTAGINGaf65f22e4729: Fix missing lock in txvalidationcache_tests.Apr 7 2020, 22:45

Revision Contents
Changeset List

PathSize
src/
test/
1 line

Diff 15937

View Options

src/test/txvalidationcache_tests.cpp

Loading...