Add LogPrint Benchmark
AbandonedPublic
Actions

Authored by nakihito on Feb 3 2020, 23:55.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

As mentioned in D5047, this a simple benchmark for the LogPrint macro
inspired by some discussion by Core in PR17218.

Test Plan

ninja bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Branch

LogPrintMacroBenchmark

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9251
Build 16445: Default Diff Build & Tests
Build 16444: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 3 2020, 23:55

Owners added a reviewer: Restricted Owners Package.Feb 3 2020, 23:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2020, 23:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox added a subscriber: jasonbcox.Feb 4 2020, 00:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9251: Diff 15982.Feb 4 2020, 00:16

Would this have detected the perf regression in PR17218? It really doesn't look obvious looking at this benchmark - in fact, I'd bet it's probably not obvious at all. But there are no numbers anywhere, we can all keep guessing.

This revision now requires changes to proceed.Feb 4 2020, 01:01

In D5144#124320, @deadalnix wrote:

Would this have detected the perf regression in PR17218? It really doesn't look obvious looking at this benchmark - in fact, I'd bet it's probably not obvious at all. But there are no numbers anywhere, we can all keep guessing.

I'm not sure what you're critique is here. It could have helped detect the performance regression if it were run before and then after the change. Are you implying that I should update the example output in doc/benchmarking.md? Is that file also meant to document benchmark statistics?

nakihito abandoned this revision.Jun 23 2020, 22:20