Avoid redundant calls to GetChainParams and GetConsensus in CChainState::AcceptBlock
ClosedPublic
Actions

Authored by deadalnix on Feb 4 2020, 15:15.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING792ee59a0321: Avoid redundant calls to GetChainParams and GetConsensus in CChainState…
rABC792ee59a0321: Avoid redundant calls to GetChainParams and GetConsensus in CChainState…

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

abrefac

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9264
Build 16470: Default Diff Build & Tests
Build 16469: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 4 2020, 15:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2020, 15:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9264: Diff 16003.Feb 4 2020, 15:20

jasonbcox accepted this revision.Feb 4 2020, 16:32

This revision is now accepted and ready to land.Feb 4 2020, 16:32

Closed by commit rABC792ee59a0321: Avoid redundant calls to GetChainParams and GetConsensus in CChainState… (authored by deadalnix). · Explain WhyFeb 4 2020, 17:24

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC792ee59a0321: Avoid redundant calls to GetChainParams and GetConsensus in CChainState….

deadalnix added a commit: rSTAGING792ee59a0321: Avoid redundant calls to GetChainParams and GetConsensus in CChainState….Apr 7 2020, 22:48

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

10 lines

Diff 16003

View Options

Avoid redundant calls to GetChainParams and GetConsensus in CChainState::AcceptBlockClosedPublicActions