Page MenuHomePhabricator
Differential D5200

[python linting] enforce E712: Comparison to true should be 'if cond is true:' or 'if cond:'
ClosedPublic
Actions

Authored by markblundeberg on Feb 7 2020, 15:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING7e8a13b4e75b: [python linting] enforce E712: Comparison to true should be 'if cond is true:'…
rABC7e8a13b4e75b: [python linting] enforce E712: Comparison to true should be 'if cond is true:'…
Summary

Note that with the RPC results it's worth checking they are exactly
as expected using is operator, but usually we just want to do a
boolean cast.

Depends on D5199

Test Plan

ninja check-all
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Feb 7 2020, 15:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 15:14
teamcity added a comment.Feb 7 2020, 15:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 7 2020, 15:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9328: Diff 16116.Feb 7 2020, 15:19
markblundeberg added a child revision: D5202: [python linting] enforce E713: Test for membership should be 'not in'.Feb 7 2020, 15:21
deadalnix accepted this revision.Feb 7 2020, 15:29
This revision is now accepted and ready to land.Feb 7 2020, 15:29
Closed by commit rABC7e8a13b4e75b: [python linting] enforce E712: Comparison to true should be 'if cond is true:'… (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 7 2020, 15:51
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC7e8a13b4e75b: [python linting] enforce E712: Comparison to true should be 'if cond is true:'….
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING7e8a13b4e75b: [python linting] enforce E712: Comparison to true should be 'if cond is true:'….Apr 7 2020, 22:52

Revision Contents
Changeset List

PathSize
2 lines
test/
functional/
2 lines
6 lines
4 lines
4 lines

Diff 16122

View Options

.arclint

Loading...
View Options

test/functional/feature_bip68_sequence.py

Loading...
View Options

test/functional/p2p_leak.py

Loading...
View Options

test/functional/wallet_disable.py

Loading...
View Options

test/functional/wallet_dump.py

Loading...