Page MenuHomePhabricator

Merge #9739: Fix BIP68 activation test
ClosedPublic

Authored by markblundeberg on Fri, Feb 7, 17:31.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC84ca20f9ba7c: Merge #9739: Fix BIP68 activation test
Summary

PR9739 backport. Seems we missed it. I noticed the same logic bug
(the assert not before_activation is useless because it just gets
covered up by the except: suppression!).

f5aba8a Move tx version 2 standardness check to after bip68 activation (John Newbery)
99c0e81 Fix BIP68 activation test (John Newbery)

Test Plan
test_runner.py feature_bip68_sequence

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Fri, Feb 7, 17:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 7, 17:32
teamcity edited the summary of this revision. (Show Details)Fri, Feb 7, 17:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

(nb there have been a variety of intervening backports so it's not quite reading identically afterwards)

deadalnix accepted this revision.Fri, Feb 7, 17:59
This revision is now accepted and ready to land.Fri, Feb 7, 17:59