Page MenuHomePhabricator
Differential D5206

Merge #9739: Fix BIP68 activation test
ClosedPublic
Actions

Authored by markblundeberg on Feb 7 2020, 17:31.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING84ca20f9ba7c: Merge #9739: Fix BIP68 activation test
rABC84ca20f9ba7c: Merge #9739: Fix BIP68 activation test
Summary

PR9739 backport. Seems we missed it. I noticed the same logic bug
(the assert not before_activation is useless because it just gets
covered up by the except: suppression!).

f5aba8a Move tx version 2 standardness check to after bip68 activation (John Newbery)
99c0e81 Fix BIP68 activation test (John Newbery)

Test Plan
test_runner.py feature_bip68_sequence

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr9739
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9336
Build 16608: Default Diff Build & Tests
Build 16607: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 7 2020, 17:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 17:32
teamcity edited the summary of this revision. (Show Details)Feb 7 2020, 17:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 7 2020, 17:32

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 7 2020, 17:37

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9336: Diff 16133.Feb 7 2020, 17:37
markblundeberg added a child revision: D5208: [python linting] enforce E722: do not use bare except.Feb 7 2020, 17:38
markblundeberg added a comment.Feb 7 2020, 17:42

(nb there have been a variety of intervening backports so it's not quite reading identically afterwards)

deadalnix accepted this revision.Feb 7 2020, 17:59
This revision is now accepted and ready to land.Feb 7 2020, 17:59
Closed by commit rABC84ca20f9ba7c: Merge #9739: Fix BIP68 activation test (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 7 2020, 18:00
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC84ca20f9ba7c: Merge #9739: Fix BIP68 activation test.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING84ca20f9ba7c: Merge #9739: Fix BIP68 activation test.Apr 7 2020, 22:53

Revision Contents
Changeset List

PathSize
test/
functional/
18 lines

Diff 16133

View Options

test/functional/feature_bip68_sequence.py

Loading...