Merge #9739: Fix BIP68 activation test
84ca20f9ba7c
Actions

Description

Merge #9739: Fix BIP68 activation test

Summary:
PR9739 backport. Seems we missed it. I noticed the same logic bug
(the assert not before_activation is useless because it just gets
covered up by the except: suppression!).

f5aba8a Move tx version 2 standardness check to after bip68 activation (John Newbery)
99c0e81 Fix BIP68 activation test (John Newbery)

Test Plan:

test_runner.py feature_bip68_sequence

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5206

Details

Provenance

Wladimir J. van der Laan <laanwj@gmail.com>	Authored on Mar 6 2017, 09:05
Mark Lundeberg <markblundeberg@users.noreply.github.com>	Committed on Feb 7 2020, 18:00
markblundeberg	Pushed on Feb 7 2020, 18:00

Reviewer

Restricted Project

Differential Revision

D5206: Merge #9739: Fix BIP68 activation test

Parents

rABCaae6d8a5aeb0: [python linting] Enforce all flake8 F codes

Branches

Unknown

Tags

Unknown

Event Timeline

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC84ca20f9ba7c: Merge #9739: Fix BIP68 activation test (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Feb 7 2020, 18:00

Mark Lundeberg <markblundeberg@users.noreply.github.com> added an edge: D5206: Merge #9739: Fix BIP68 activation test.