Page MenuHomePhabricator

Merge #17455: tests: Update valgrind suppressions
ClosedPublic

Authored by markblundeberg on Feb 11 2020, 05:11.

Details

Summary

Backport PR17455


Backport note:
I've run the same generator and the only thing it turns up currently
is the LogInstance reachable leak (which is intentional, see logger.cpp).
However it's likely we'll see the other reachable leaks appear in
future backports, so might as well include them now.

Note that --child-silent-after-fork=yes is necessary on all valgrind
test_bitcoin runs after D5254, so comments have been updated accordingly.

Result valgrinding test_bitcoin shows no leaks after suppressions:

==28408== HEAP SUMMARY:
==28408==     in use at exit: 1,088 bytes in 5 blocks
==28408==   total heap usage: 182,020,544 allocs, 182,020,539 frees, 31,333,403,759 bytes allocated

We do have some leaks in bench-bitcoin CoinSelection test, likely
need PR14822.

Depends on D5254

Test Plan

Borrowed from the PR -- run from build dir

valgrind --suppressions=../contrib/valgrind.supp --child-silent-after-fork=yes src/test/test_bitcoin
valgrind --suppressions=../contrib/valgrind.supp src/bench/bitcoin-bench -evals=1 -scaling=0.0

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D5251
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9426
Build 16781: Default Diff Build & Tests
Build 16780: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

markblundeberg edited the test plan for this revision. (Show Details)
markblundeberg added a reviewer: Fabien.

(the 5 remaining reachable leaked blocks are: 4 from leveldb, 1 from LogInstance)

update comments with --child-silent-after-fork=yes

Fabien added inline comments.
contrib/valgrind.supp
70 ↗(On Diff #16260)

Nit: you can leave the glibc bug suppression at the end, it could help to avoid future merge conflicts a bit.

This revision is now accepted and ready to land.Feb 11 2020, 10:48