Page MenuHomePhabricator

Merge #14679: importmulti: Don't add internal addresses to address book
ClosedPublic

Authored by nakihito on Fri, Feb 14, 01:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC937a91eb9ebc: Merge #14679: importmulti: Don't add internal addresses to address book
Summary

7afddfa8cefd01249ad59cf2370e7cec90b34f6f importmulti: Don't add internal addresses to address book (Gregory Sanders)

Pull request description:

Currently anything imported with `internal` will not be treated as change since checking the address book is a primary test of this.

Added basic tests of all combinations of arguments and change identification.

Resolves https://github.com/bitcoin/bitcoin/issues/14662

Tree-SHA512: a1f08dc624a3fadee93cc5392d50c4796b0c5eedf38e295382f71570f2066d9e978ed6e3962084b902989863fe1273a8642d8fdb094a266d69de10622a4176b0

Backport of Core PR14679
https://github.com/bitcoin/bitcoin/pull/14679/

Test Plan
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help importmulti

Verify changes to help text.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Fri, Feb 14, 01:11
Owners added a reviewer: Restricted Owners Package.Fri, Feb 14, 01:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 14, 01:11
teamcity edited the summary of this revision. (Show Details)Fri, Feb 14, 01:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien accepted this revision.Fri, Feb 14, 09:31
This revision is now accepted and ready to land.Fri, Feb 14, 09:31