Merge #14679: importmulti: Don't add internal addresses to address book
ClosedPublic
Actions

Authored by nakihito on Feb 14 2020, 01:11.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING937a91eb9ebc: Merge #14679: importmulti: Don't add internal addresses to address book
rABC937a91eb9ebc: Merge #14679: importmulti: Don't add internal addresses to address book

Summary

7afddfa8cefd01249ad59cf2370e7cec90b34f6f importmulti: Don't add internal addresses to address book (Gregory Sanders)

Pull request description:

Currently anything imported with `internal` will not be treated as change since checking the address book is a primary test of this.

Added basic tests of all combinations of arguments and change identification.

Resolves https://github.com/bitcoin/bitcoin/issues/14662

Tree-SHA512: a1f08dc624a3fadee93cc5392d50c4796b0c5eedf38e295382f71570f2066d9e978ed6e3962084b902989863fe1273a8642d8fdb094a266d69de10622a4176b0

Backport of Core PR14679
https://github.com/bitcoin/bitcoin/pull/14679/

Test Plan

ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help importmulti

Verify changes to help text.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Feb 14 2020, 01:11

Owners added a reviewer: Restricted Owners Package.Feb 14 2020, 01:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 14 2020, 01:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9492: Diff 16374.Feb 14 2020, 01:32

Fabien accepted this revision.Feb 14 2020, 09:31

This revision is now accepted and ready to land.Feb 14 2020, 09:31

Closed by commit rABC937a91eb9ebc: Merge #14679: importmulti: Don't add internal addresses to address book (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyFeb 14 2020, 18:24

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC937a91eb9ebc: Merge #14679: importmulti: Don't add internal addresses to address book.

nakihito added a commit: rSTAGING937a91eb9ebc: Merge #14679: importmulti: Don't add internal addresses to address book.Apr 7 2020, 23:01

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcdump.cpp

7 lines

test/

functional/

wallet_importmulti.py

9 lines

Diff 16384

View Options

src/wallet/rpcdump.cpp