Page MenuHomePhabricator

Merge #14679: importmulti: Don't add internal addresses to address book
ClosedPublic

Authored by nakihito on Feb 14 2020, 01:11.

Details

Summary

7afddfa8cefd01249ad59cf2370e7cec90b34f6f importmulti: Don't add internal addresses to address book (Gregory Sanders)

Pull request description:

Currently anything imported with `internal` will not be treated as change since checking the address book is a primary test of this.

Added basic tests of all combinations of arguments and change identification.

Resolves https://github.com/bitcoin/bitcoin/issues/14662

Tree-SHA512: a1f08dc624a3fadee93cc5392d50c4796b0c5eedf38e295382f71570f2066d9e978ed6e3962084b902989863fe1273a8642d8fdb094a266d69de10622a4176b0

Backport of Core PR14679
https://github.com/bitcoin/bitcoin/pull/14679/

Test Plan
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help importmulti

Verify changes to help text.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14679
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9492
Build 16897: Default Diff Build & Tests
Build 16896: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Feb 14 2020, 01:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Feb 14 2020, 09:31