HomePhabricator

Merge #14679: importmulti: Don't add internal addresses to address book

Description

Merge #14679: importmulti: Don't add internal addresses to address book

Summary:
7afddfa8cefd01249ad59cf2370e7cec90b34f6f importmulti: Don't add internal addresses to address book (Gregory Sanders)

Pull request description:

Currently anything imported with `internal` will not be treated as change since checking the address book is a primary test of this.

Added basic tests of all combinations of arguments and change identification.

Resolves https://github.com/bitcoin/bitcoin/issues/14662

Tree-SHA512: a1f08dc624a3fadee93cc5392d50c4796b0c5eedf38e295382f71570f2066d9e978ed6e3962084b902989863fe1273a8642d8fdb094a266d69de10622a4176b0

Backport of Core PR14679
https://github.com/bitcoin/bitcoin/pull/14679/

Test Plan:

ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help importmulti

Verify changes to help text.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5288

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Nov 13 2018, 20:31
nakihitoCommitted on Feb 14 2020, 18:24
jasonbcoxPushed on Feb 14 2020, 19:45
Reviewer
Restricted Owners Package
Differential Revision
D5288: Merge #14679: importmulti: Don't add internal addresses to address book
Parents
rSTAGING6af55e8d098f: Add --commit to automated-commits to make local testing easier
Branches
Unknown
Tags
Unknown