Page MenuHomePhabricator

[sigcheck] Remove redundant sigcheck in CheckInputs
ClosedPublic

Authored by deadalnix on Feb 15 2020, 16:19.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCb9912939d5a9: [sigcheck] Remove redundant sigcheck in CheckInputs
Summary

The call to check checks for sigops - which is a better place to do it anyways.

Test Plan

Updated test to cover the error.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Feb 15 2020, 16:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 15 2020, 16:19
jasonbcox requested changes to this revision.Feb 15 2020, 16:54
jasonbcox added a subscriber: jasonbcox.

There's a comment regarding this behavior in validation.h:490 that needs updating.

This revision now requires changes to proceed.Feb 15 2020, 16:54
deadalnix requested review of this revision.Feb 15 2020, 17:39

The comment is still accurate. The behavior did not change, as tests demonstrate.

jasonbcox accepted this revision.Feb 15 2020, 17:42
This revision is now accepted and ready to land.Feb 15 2020, 17:42
This revision was automatically updated to reflect the committed changes.