Page MenuHomePhabricator

[sigcheck] Remove redundant sigcheck in CheckInputs
ClosedPublic

Authored by deadalnix on Feb 15 2020, 16:19.

Details

Summary

The call to check checks for sigops - which is a better place to do it anyways.

Test Plan

Updated test to cover the error.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
removeredundantsigcheck
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9512
Build 16936: Default Diff Build & Tests
Build 16935: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Feb 15 2020, 16:54
jasonbcox added a subscriber: jasonbcox.

There's a comment regarding this behavior in validation.h:490 that needs updating.

This revision now requires changes to proceed.Feb 15 2020, 16:54

The comment is still accurate. The behavior did not change, as tests demonstrate.

This revision is now accepted and ready to land.Feb 15 2020, 17:42