[sigcheck] Remove redundant sigcheck in CheckInputs
ClosedPublic
Actions

Authored by deadalnix on Feb 15 2020, 16:19.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGb9912939d5a9: [sigcheck] Remove redundant sigcheck in CheckInputs
rABCb9912939d5a9: [sigcheck] Remove redundant sigcheck in CheckInputs

Summary

The call to check checks for sigops - which is a better place to do it anyways.

Test Plan

Updated test to cover the error.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

removeredundantsigcheck

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9512
Build 16936: Default Diff Build & Tests
Build 16935: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 15 2020, 16:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 15 2020, 16:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9512: Diff 16408.Feb 15 2020, 16:42

There's a comment regarding this behavior in validation.h:490 that needs updating.

This revision now requires changes to proceed.Feb 15 2020, 16:54

The comment is still accurate. The behavior did not change, as tests demonstrate.

jasonbcox accepted this revision.Feb 15 2020, 17:42

This revision is now accepted and ready to land.Feb 15 2020, 17:42

Closed by commit rABCb9912939d5a9: [sigcheck] Remove redundant sigcheck in CheckInputs (authored by deadalnix). · Explain WhyFeb 15 2020, 18:03

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCb9912939d5a9: [sigcheck] Remove redundant sigcheck in CheckInputs.

deadalnix added a commit: rSTAGINGb9912939d5a9: [sigcheck] Remove redundant sigcheck in CheckInputs.Apr 7 2020, 23:02

Revision Contents
Changeset List

Path

Size

src/

test/

txvalidationcache_tests.cpp

4 lines

validation.cpp

7 lines

Diff 16408

View Options

src/test/txvalidationcache_tests.cpp