Page MenuHomePhabricator
Differential D5299

[ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing as we go
ClosedPublic
Actions

Authored by deadalnix on Feb 15 2020, 16:43.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGff9578c4bcd3: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing…
rABCff9578c4bcd3: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing…
Summary

This makes the code more solid as there is no risk of reallocation mid way.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9513
Build 16938: Default Diff Build & Tests
Build 16937: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 15 2020, 16:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 15 2020, 16:43
teamcity added a comment.Feb 15 2020, 16:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox requested changes to this revision.Feb 15 2020, 17:02
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
1912

Any reason to not move this initialization down to where txIndex is initialized? It isn't used until that loop anyway, and block.vtx.size() doesn't change.

This revision now requires changes to proceed.Feb 15 2020, 17:02
teamcity added a comment.Feb 15 2020, 17:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9513: Diff 16409.Feb 15 2020, 17:05
deadalnix requested review of this revision.Feb 15 2020, 17:40
deadalnix added inline comments.
src/validation.cpp
1912

This is where everything is setup. If anything we'd have to move the other loop up, but this doesn't seem like the best move for this patch.

jasonbcox accepted this revision.Feb 15 2020, 17:42
This revision is now accepted and ready to land.Feb 15 2020, 17:42
Closed by commit rABCff9578c4bcd3: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing… (authored by deadalnix). · Explain WhyFeb 15 2020, 18:01
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCff9578c4bcd3: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing….
deadalnix added a commit: rSTAGINGff9578c4bcd3: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing….Apr 7 2020, 23:01

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 16409

View Options

src/validation.cpp

Loading...