Page MenuHomePhabricator

[sigcheck] Add per tx limit
ClosedPublic

Authored by deadalnix on Feb 16 2020, 02:38.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC18708a54d44c: [sigcheck] Add per tx limit
Summary

As per title.

Test Plan

Added integration tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Feb 16 2020, 02:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 16 2020, 02:38
jasonbcox requested changes to this revision.Feb 16 2020, 03:42
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
1225 ↗(On Diff #16414)

Won't this short circuit so pBlockLimitSigChecks->consume_and_check(metrics.nSigChecks) may not be evaluated?

1273 ↗(On Diff #16414)

ditto

src/validation.h
524 ↗(On Diff #16414)

Nit: s/for to/to

test/functional/abc-block-sigchecks-activation.py
298 ↗(On Diff #16414)

s/may/many ?

This revision now requires changes to proceed.Feb 16 2020, 03:42
deadalnix updated this revision to Diff 16416.Feb 16 2020, 03:47

Fix nits

jasonbcox accepted this revision.Feb 16 2020, 03:48
jasonbcox added inline comments.
src/validation.cpp
1225 ↗(On Diff #16414)

nvm, the tx limit check failing is the only case where this does not short circuit, so it doesn't matter.

This revision is now accepted and ready to land.Feb 16 2020, 03:48
deadalnix updated this revision to Diff 16418.Feb 16 2020, 03:55

More nits

This revision was landed with ongoing or failed builds.Feb 16 2020, 03:56
This revision was automatically updated to reflect the committed changes.